Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix focus #679

Closed
wants to merge 3 commits into from
Closed

fix: fix focus #679

wants to merge 3 commits into from

Conversation

yoyo837
Copy link
Member

@yoyo837 yoyo837 commented Dec 5, 2023

ref: #671

src/Menu.tsx Show resolved Hide resolved
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (67baccb) 99.58% compared to head (4f140f8) 99.30%.

Files Patch % Lines
src/Menu.tsx 66.66% 1 Missing ⚠️
src/hooks/useAccessibility.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #679      +/-   ##
==========================================
- Coverage   99.58%   99.30%   -0.28%     
==========================================
  Files          27       27              
  Lines         718      722       +4     
  Branches      193      194       +1     
==========================================
+ Hits          715      717       +2     
- Misses          3        5       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/Menu.tsx Outdated Show resolved Hide resolved
@yoyo837
Copy link
Member Author

yoyo837 commented Dec 5, 2023

我调试发现在 antd 的 test case 中,用例失败是因为 focus 的时候 li 没有宽高,认为 unfocusable 然后 filter 掉了 , 而 rc-menu 的用例始终成功是用例运行时,li 有宽高,是 focusable

image

@yoyo837 yoyo837 mentioned this pull request Dec 6, 2023
@MadCcc MadCcc closed this in #680 Dec 6, 2023
@yoyo837 yoyo837 deleted the fix-focus branch December 6, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants