Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Menu.Item not support ref #616

Merged
merged 2 commits into from
Apr 6, 2023
Merged

fix: Menu.Item not support ref #616

merged 2 commits into from
Apr 6, 2023

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Apr 6, 2023

As antd internal patch ref on Menu.Item. We need make it support ref. It's safe to remove after refactor.

fix ant-design/ant-design#41570

@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Merging #616 (6ae26ce) into master (e196d2e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 6ae26ce differs from pull request most recent head b3f8e2c. Consider uploading reports for the commit b3f8e2c to get more accurate results

@@           Coverage Diff           @@
##           master     #616   +/-   ##
=======================================
  Coverage   99.85%   99.85%           
=======================================
  Files          26       26           
  Lines         710      712    +2     
  Branches      191      191           
=======================================
+ Hits          709      711    +2     
  Misses          1        1           
Impacted Files Coverage Δ
src/MenuItem.tsx 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zombieJ zombieJ merged commit 805be3d into master Apr 6, 2023
@zombieJ zombieJ deleted the item-ref branch April 6, 2023 06:16
@afc163
Copy link
Member

afc163 commented Apr 6, 2023

ant-design/ant-design#41657
ant-design/ant-design#35361

看看是不是都修复了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using <Dropdown> results in "findDOMNode is deprecated in StrictMode" warning
2 participants