Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove all coupling code #218

Merged
merged 3 commits into from
May 30, 2022
Merged

refactor: Remove all coupling code #218

merged 3 commits into from
May 30, 2022

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented May 30, 2022

  • 移除全部注入内容:className、prefixCls、events
  • onClick 事件迁移至 rc-trigger 处理
  • onOverlayClick 事件参数移除,好在在 antd 中没有透出不会 breaking change

antd 侧还需要 context 改造。

ref ant-design/ant-design#35584 (comment)

@codecov
Copy link

codecov bot commented May 30, 2022

Codecov Report

Merging #218 (d671cbd) into master (68a6e42) will not change coverage.
The diff coverage is 100.00%.

❗ Current head d671cbd differs from pull request most recent head f41483d. Consider uploading reports for the commit f41483d to get more accurate results

@@            Coverage Diff            @@
##            master      #218   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          107       104    -3     
  Branches        31        30    -1     
=========================================
- Hits           107       104    -3     
Impacted Files Coverage Δ
src/Dropdown.tsx 100.00% <100.00%> (ø)
src/hooks/useAccessibility.ts 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@zombieJ zombieJ merged commit a0d1785 into master May 30, 2022
@delete-merged-branch delete-merged-branch bot deleted the new branch May 30, 2022 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant