Skip to content

Commit 97124db

Browse files
authored
Revert "fix: 31039 (#215)" (#227)
This reverts commit a9d2a52.
1 parent 7d9422e commit 97124db

2 files changed

Lines changed: 10 additions & 36 deletions

File tree

src/Panel.tsx

Lines changed: 10 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -54,11 +54,10 @@ class CollapsePanel extends React.Component<CollapsePanelProps, any> {
5454
} = this.props;
5555

5656
const disabled = collapsible === 'disabled';
57-
const collapsibleHeader = collapsible === 'header';
5857

5958
const headerCls = classNames(`${prefixCls}-header`, {
6059
[headerClass]: headerClass,
61-
[`${prefixCls}-header-collapsible-only`]: collapsibleHeader,
60+
[`${prefixCls}-header-collapsible-only`]: collapsible === 'header',
6261
});
6362
const itemCls = classNames(
6463
{
@@ -70,36 +69,24 @@ class CollapsePanel extends React.Component<CollapsePanelProps, any> {
7069
);
7170

7271
let icon: any = <i className="arrow" />;
73-
74-
/** header 节点属性 */
75-
const headerProps: React.HTMLAttributes<HTMLDivElement> = {
76-
className: headerCls,
77-
'aria-expanded': isActive,
78-
onKeyPress: this.handleKeyPress,
79-
};
80-
8172
if (showArrow && typeof expandIcon === 'function') {
8273
icon = expandIcon(this.props);
8374
}
84-
if (collapsibleHeader) {
85-
icon = (
86-
<span style={{ cursor: 'pointer' }} onClick={() => this.handleItemClick()}>
87-
{icon}
88-
</span>
89-
);
90-
} else {
91-
headerProps.onClick = this.handleItemClick;
92-
headerProps.role = accordion ? 'tab' : 'button';
93-
headerProps.tabIndex = disabled ? -1 : 0;
94-
}
9575

9676
const ifExtraExist = extra !== null && extra !== undefined && typeof extra !== 'boolean';
9777

9878
return (
9979
<div className={itemCls} style={style} id={id}>
100-
<div {...headerProps}>
80+
<div
81+
className={headerCls}
82+
onClick={() => collapsible !== 'header' && this.handleItemClick()}
83+
role={accordion ? 'tab' : 'button'}
84+
tabIndex={disabled ? -1 : 0}
85+
aria-expanded={isActive}
86+
onKeyPress={this.handleKeyPress}
87+
>
10188
{showArrow && icon}
102-
{collapsibleHeader ? (
89+
{collapsible === 'header' ? (
10390
<span onClick={this.handleItemClick} className={`${prefixCls}-header-text`}>
10491
{header}
10592
</span>

tests/index.spec.tsx

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -545,18 +545,5 @@ describe('collapse', () => {
545545
collapse.find('.rc-collapse-header').simulate('click');
546546
expect(collapse.find('.rc-collapse-item-active').length).toBe(0);
547547
});
548-
549-
it('icon trigger when collapsible equal header', () => {
550-
const collapse = mount(
551-
<Collapse collapsible="header">
552-
<Panel header="collapse 1" key="1">
553-
first
554-
</Panel>
555-
</Collapse>,
556-
);
557-
558-
collapse.find('.rc-collapse-header .arrow').simulate('click');
559-
expect(collapse.find('.rc-collapse-item-active').length).toBe(1);
560-
});
561548
});
562549
});

0 commit comments

Comments
 (0)