Skip to content

Commit 3f8ae43

Browse files
committed
fix: search no scroll
1 parent d15d83b commit 3f8ae43

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

src/OptionList/Column.tsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ export interface ColumnProps<OptionType extends DefaultOptionType = DefaultOptio
2323
halfCheckedSet: Set<React.Key>;
2424
loadingKeys: React.Key[];
2525
isSelectable: (option: DefaultOptionType) => boolean;
26-
searchValue?: string;
2726
}
2827

2928
export default function Column<OptionType extends DefaultOptionType = DefaultOptionType>({
@@ -39,7 +38,6 @@ export default function Column<OptionType extends DefaultOptionType = DefaultOpt
3938
halfCheckedSet,
4039
loadingKeys,
4140
isSelectable,
42-
searchValue,
4341
}: ColumnProps<OptionType>) {
4442
const menuPrefixCls = `${prefixCls}-menu`;
4543
const menuItemPrefixCls = `${prefixCls}-menu-item`;
@@ -117,7 +115,7 @@ export default function Column<OptionType extends DefaultOptionType = DefaultOpt
117115
}) => {
118116
// >>>>> Open
119117
const triggerOpenPath = () => {
120-
if (disabled || searchValue) {
118+
if (disabled) {
121119
return;
122120
}
123121
const nextValueCells = [...fullPath];

src/OptionList/List.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -166,6 +166,7 @@ const RawOptionList = React.forwardRef<RefOptionListProps, RawOptionListProps>((
166166

167167
// >>>>> Active Scroll
168168
React.useEffect(() => {
169+
if (searchValue) return;
169170
for (let i = 0; i < activeValueCells.length; i += 1) {
170171
const cellPath = activeValueCells.slice(0, i + 1);
171172
const cellKeyPath = toPathKey(cellPath);
@@ -176,7 +177,7 @@ const RawOptionList = React.forwardRef<RefOptionListProps, RawOptionListProps>((
176177
scrollIntoParentView(ele);
177178
}
178179
}
179-
}, [activeValueCells]);
180+
}, [activeValueCells, searchValue]);
180181

181182
// ========================== Render ==========================
182183
// >>>>> Empty
@@ -213,7 +214,6 @@ const RawOptionList = React.forwardRef<RefOptionListProps, RawOptionListProps>((
213214
<Column
214215
key={index}
215216
{...columnProps}
216-
searchValue={searchValue}
217217
prefixCls={mergedPrefixCls}
218218
options={col.options}
219219
prevValuePath={prevValuePath}

0 commit comments

Comments
 (0)