Skip to content

add rowKey to selectionRenderer function #1139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

chimericdream
Copy link
Contributor

I was writing a custom renderer for the selection cell in order to add a label to the input for screen readers. But I realized that the rowIndex being passed in cannot reliably be used to get the row data, since filtering and sorting affect it.

This change merely adds the rowKey as an additional param to custom selectionRenderer functions.

@AllenFang AllenFang changed the base branch from master to develop November 9, 2019 07:22
@AllenFang
Copy link
Member

@chimericdream the target branch should be develop, so I switch to it but I need you to rebase code again. thanks your contributions.

@chimericdream
Copy link
Contributor Author

Closing this PR to re-open as develop -> develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants