Skip to content

Commit ac66888

Browse files
authored
Update README.textile
Note security, thanks Emil
1 parent ee85b64 commit ac66888

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

README.textile

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,10 @@ h2. History and Background
1616

1717
h2. Pre-requisites and Installation
1818

19-
1. Install XQuartz from here:
19+
1. (mac) Install XQuartz from here:
2020
@http://xquartz.macosforge.org/landing/@
2121

22-
2. Install gnuplot with homebrew:
22+
2. Install gnuplot with homebrew (not OS X? install it using your package manager):
2323
@brew install gnuplot --with-x11@
2424

2525
3. Install gnuplot gem:
@@ -188,6 +188,8 @@ File.open( "gnuplot.dat", "w") do |gp|
188188
end
189189
</pre>
190190

191+
h3. Miscellanrous
192+
191193
You can also add arbitrary lines to the output
192194

193195
<pre>
@@ -196,3 +198,9 @@ plot.arbitrary_lines << "set ylabel \"y label\" font \"Helvetica,20\""
196198

197199
See more in the examples folder. Also since this is basically just a wrapper for gnuplot itself, you should be able to do anything that it can do (demos:
198200
http://gnuplot.sourceforge.net/demo_4.4/ )
201+
202+
h3. Security
203+
204+
Note that if you pass any user-controlled strings to the gem, it's possible for an attacker to run arbitrary commands.
205+
206+
In addition to title, any other graph properties that accept strings should be affected too. they're all passed to the system command. So only use strings you trust.

0 commit comments

Comments
 (0)