Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve doc in linux-object and migrate some simple syscalls #142

Merged
merged 8 commits into from
Aug 12, 2020

Conversation

yunwei37
Copy link
Contributor

@yunwei37 yunwei37 commented Aug 11, 2020

Add syscalls

  • sysinfo
  • flock

Maybe some of them are just interfaces...

  • I'm trying to port symlink syscall from rcore, but the rcorefs-hostfs is not support it (and some other syscall is not support well), so maybe I can make some change to this?
  • this pull-request maybe only for some simple things...

other

  • add some simple syscall tests
  • fix some syscall info log
  • change some schedule syscall to unimplement

@coveralls
Copy link

coveralls commented Aug 11, 2020

Pull Request Test Coverage Report for Build 205410702

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 33 of 47 (70.21%) changed or added relevant lines in 8 files are covered.
  • 1046 unchanged lines in 30 files lost coverage.
  • Overall coverage increased (+2.2%) to 43.798%

Changes Missing Coverage Covered Lines Changed/Added Lines %
linux-syscall/src/misc.rs 18 19 94.74%
linux-syscall/src/task.rs 1 2 50.0%
linux-syscall/src/lib.rs 2 4 50.0%
linux-syscall/src/file/poll.rs 0 3 0.0%
linux-syscall/src/file/fd.rs 0 7 0.0%
Files with Coverage Reduction New Missed Lines %
zircon-syscall/src/lib.rs 1 0.0%
linux-syscall/src/misc.rs 2 43.33%
zircon-syscall/src/resource.rs 3 0.0%
zircon-syscall/src/debug.rs 4 0.0%
linux-object/src/fs/file.rs 5 58.82%
zircon-syscall/src/cprng.rs 5 0.0%
../../../../../usr/share/rust/.cargo/registry/src/github.com-1ecc6299db9ec823/bitflags-1.2.1/src/lib.rs 9 42.86%
zircon-syscall/src/port.rs 9 0.0%
zircon-syscall/src/system.rs 9 0.0%
zircon-syscall/src/fifo.rs 15 0.0%
Totals Coverage Status
Change from base Build 204048433: 2.2%
Covered Lines: 5985
Relevant Lines: 13665

💛 - Coveralls

@yunwei37
Copy link
Contributor Author

yunwei37 commented Aug 12, 2020

about rustc

Currently we can run rustc with help informations output, but cannot compile files.

It seems poll syscall may have some bugs or unexpected behavior with pipe, maybe because the pipe has not imply the async_poll. I think it can be fix in the future.

@yunwei37 yunwei37 marked this pull request as ready for review August 12, 2020 10:48
@wangrunji0408 wangrunji0408 self-requested a review August 12, 2020 11:17
@wangrunji0408 wangrunji0408 added enhancement New feature or request documentation Improvements or additions to documentation labels Aug 12, 2020
Copy link
Member

@wangrunji0408 wangrunji0408 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wangrunji0408 wangrunji0408 merged commit 37e7ae1 into rcore-os:master Aug 12, 2020
@wangrunji0408
Copy link
Member

You are welcomed to add symlink support for rcore-fs-hostfs :)

zhangsn-19 pushed a commit to zhangsn-19/zCore that referenced this pull request Apr 23, 2022
Improve doc in `linux-object` and migrate some simple syscalls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants