Remove legacy 7.1 method from vtkBase64Utilities

Remove an unsafe decode method.

Author: aronhelser

IO/Core/vtkBase64Utilities.cxx

@@ -210,76 +210,6 @@ int vtkBase64Utilities::DecodeTriplet(unsigned char i0,
   return 3;
 }
 
-#if !defined(VTK_LEGACY_REMOVE)
-//----------------------------------------------------------------------------
-unsigned long vtkBase64Utilities::Decode(const unsigned char *input,
-                                         unsigned long length,
-                                         unsigned char *output,
-                                         unsigned long max_input_length)
-{
-  VTK_LEGACY_REPLACED_BODY(Decode, "VTK 7.1", DecodeSafely);
-
-  const unsigned char *ptr = input;
-  unsigned char *optr = output;
-
-  // Decode complete triplet
-
-  if (max_input_length)
-  {
-    const unsigned char *end = input + max_input_length;
-    while (ptr < end)
-    {
-      int len =
-        vtkBase64Utilities::DecodeTriplet(ptr[0], ptr[1], ptr[2], ptr[3],
-                                          &optr[0], &optr[1], &optr[2]);
-      optr += len;
-      if(len < 3)
-      {
-        return optr - output;
-      }
-      ptr += 4;
-    }
-  }
-  else
-  {
-    unsigned char *oend = output + length;
-    while ((oend - optr) >= 3)
-    {
-      int len =
-        vtkBase64Utilities::DecodeTriplet(ptr[0], ptr[1], ptr[2], ptr[3],
-                                          &optr[0], &optr[1], &optr[2]);
-      optr += len;
-      if(len < 3)
-      {
-        return optr - output;
-      }
-      ptr += 4;
-    }
-
-    // Decode the last triplet
-
-    unsigned char temp;
-    if (oend - optr == 2)
-    {
-      int len =
-        vtkBase64Utilities::DecodeTriplet(ptr[0], ptr[1], ptr[2], ptr[3],
-                                          &optr[0], &optr[1], &temp);
-      optr += (len > 2 ? 2 : len);
-    }
-    else if (oend - optr == 1)
-    {
-      unsigned char temp2;
-      int len =
-        vtkBase64Utilities::DecodeTriplet(ptr[0], ptr[1], ptr[2], ptr[3],
-                                          &optr[0], &temp, &temp2);
-      optr += (len > 2 ? 2 : len);
-    }
-  }
-
-  return optr - output;
-}
-#endif
-
 //----------------------------------------------------------------------------
 size_t vtkBase64Utilities::DecodeSafely(const unsigned char *input,
                                         size_t inputLen,

IO/Core/vtkBase64Utilities.h

@@ -79,7 +79,6 @@ class VTKIOCORE_EXPORT vtkBase64Utilities : public vtkObject
                               unsigned char *output,
                               int mark_end = 0);
 
-
   /**
    * Decode 4 bytes into 3 bytes.
    * Return the number of bytes actually decoded (0 to 3, inclusive).
@@ -92,23 +91,6 @@ class VTKIOCORE_EXPORT vtkBase64Utilities : public vtkObject
                            unsigned char *o1,
                            unsigned char *o2);
 
-  /**
-   * Decode bytes from the input buffer and store the decoded stream
-   * into the output buffer until 'length' bytes have been decoded.
-   * Return the real length of the decoded stream (which should be equal to
-   * 'length'). Note that the output buffer must be allocated by the caller.
-   * If 'max_input_length' is not 0, then it specifies the number of
-   * encoded bytes that should be at most read from the input buffer. In
-   * that case the 'length' parameter is ignored. This enables the caller
-   * to decode a stream without actually knowing how much decoded data to
-   * expect (of course, the buffer must be large enough).
-   * \deprecated: This method can easily overrun its buffers, use DecodeSafely.
-   */
-  VTK_LEGACY(static unsigned long Decode(const unsigned char *input,
-                                         unsigned long length,
-                                         unsigned char *output,
-                                         unsigned long max_input_length = 0));
-
   /**
    * Decode 4 bytes at a time from the input buffer and store the decoded
    * stream into the output buffer. The required output buffer size must be