Fix onLaneScroll not working on different screen sizes #422 #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corvec
reviewed
Feb 8, 2021
src/controllers/Lane.js
Outdated
| @@ -26,7 +26,7 @@ class Lane extends Component { | |||
| const node = evt.target | |||
| const elemScrollPosition = node.scrollHeight - node.scrollTop - node.clientHeight | |||
| const {onLaneScroll} = this.props | |||
| if (elemScrollPosition <= 0 && onLaneScroll && !this.state.loading) { | |||
| if (elemScrollPosition <= 1 && onLaneScroll && !this.state.loading) { | |||
There was a problem hiding this comment.
Yes, that'd work too. Normally the difference is never going to be 1 or more.
There was a problem hiding this comment.
Hi guys! It's very cool that you fixes that issue!
I believe it's better to describe this line and put a link to the issue. Because if you do not know the reason, then this code looks strange.
Also I prefer < 1 )
dapi
requested changes
Feb 9, 2021
src/controllers/Lane.js
Outdated
| @@ -26,7 +26,7 @@ class Lane extends Component { | |||
| const node = evt.target | |||
| const elemScrollPosition = node.scrollHeight - node.scrollTop - node.clientHeight | |||
| const {onLaneScroll} = this.props | |||
| if (elemScrollPosition <= 0 && onLaneScroll && !this.state.loading) { | |||
| if (elemScrollPosition <= 1 && onLaneScroll && !this.state.loading) { | |||
There was a problem hiding this comment.
Hi guys! It's very cool that you fixes that issue!
I believe it's better to describe this line and put a link to the issue. Because if you do not know the reason, then this code looks strange.
Also I prefer < 1 )
dapi
approved these changes
Feb 10, 2021
|
🎉 This PR is included in version 2.2.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#422