Issue with Lane Pagination due to micro difference between scrollTop and scrollHeight.

[deve-sh]

react-trello/src/controllers/Lane.js

Line 27 in 58d5396

const elemScrollPosition = node.scrollHeight - node.scrollTop - node.clientHeight

Hey There, thanks for the brilliant library, it's very useful. I have an issue with the lane pagination. The issue isn't directly reproducable but is noticeable at certain times due to screen size differences and the ways in which the lane scroll container is styled.

It is noticeable in certain scenarios that scrollHeight or scrollTop are off by a margin of less than 1px, for example: Instead of 692px they will be 691.45555555px. The elemScrollPosition variable might be greater than 0 in some cases due to that even though the user has scrolled all the way down and is expecting more cards to load.

Suggest using something like Math.floor or Math.ceil in combination with node.offsetHeight to counter that issue.

[oliviervanbulck]

I believe I have the same problem. My lanes are having a dynamic height based on the window height. On my laptop screen it's not workingat all, on my second screen everything works perfectly.

Edit: I tested this and checked the values and my elemScrollPosition is 0,7998046875 when scrolled to the bottom.

[oliviervanbulck]

I added a pull request for this by changing the check to maximum 1. That should work.

[deve-sh]

Thank you so much. Hoping for the issue to be resolved in the next release.

[deve-sh]

Closing this issue since this has already been fixed with the mentioned PR long ago. #431