fix milesburton#97 - replace char with int8_t to make type explicitly signed

Author: RobTillaart

DallasTemperature.cpp

@@ -636,7 +636,7 @@ float DallasTemperature::rawToFahrenheit(int16_t raw) {
 // accepts a float, but the alarm resolution will ignore anything
 // after a decimal point.  valid range is -55C - 125C
 void DallasTemperature::setHighAlarmTemp(const uint8_t* deviceAddress,
-		char celsius) {
+		int8_t celsius) {
 
 	// return when stored value == new value
 	if (getHighAlarmTemp(deviceAddress) == celsius)
@@ -660,7 +660,7 @@ void DallasTemperature::setHighAlarmTemp(const uint8_t* deviceAddress,
 // accepts a float, but the alarm resolution will ignore anything
 // after a decimal point.  valid range is -55C - 125C
 void DallasTemperature::setLowAlarmTemp(const uint8_t* deviceAddress,
-		char celsius) {
+		int8_t celsius) {
 
 	// return when stored value == new value
 	if (getLowAlarmTemp(deviceAddress) == celsius)
@@ -680,24 +680,24 @@ void DallasTemperature::setLowAlarmTemp(const uint8_t* deviceAddress,
 
 }
 
-// returns a char with the current high alarm temperature or
+// returns a int8_t with the current high alarm temperature or
 // DEVICE_DISCONNECTED for an address
-char DallasTemperature::getHighAlarmTemp(const uint8_t* deviceAddress) {
+int8_t DallasTemperature::getHighAlarmTemp(const uint8_t* deviceAddress) {
 
 	ScratchPad scratchPad;
 	if (isConnected(deviceAddress, scratchPad))
-		return (char) scratchPad[HIGH_ALARM_TEMP];
+		return (int8_t) scratchPad[HIGH_ALARM_TEMP];
 	return DEVICE_DISCONNECTED_C;
 
 }
 
-// returns a char with the current low alarm temperature or
+// returns a int8_t with the current low alarm temperature or
 // DEVICE_DISCONNECTED for an address
-char DallasTemperature::getLowAlarmTemp(const uint8_t* deviceAddress) {
+int8_t DallasTemperature::getLowAlarmTemp(const uint8_t* deviceAddress) {
 
 	ScratchPad scratchPad;
 	if (isConnected(deviceAddress, scratchPad))
-		return (char) scratchPad[LOW_ALARM_TEMP];
+		return (int8_t) scratchPad[LOW_ALARM_TEMP];
 	return DEVICE_DISCONNECTED_C;
 
 }
@@ -728,7 +728,7 @@ void DallasTemperature::resetAlarmSearch() {
 bool DallasTemperature::alarmSearch(uint8_t* newAddr) {
 
 	uint8_t i;
-	char lastJunction = -1;
+	int8_t lastJunction = -1;
 	uint8_t done = 1;
 
 	if (alarmSearchExhausted)
@@ -800,14 +800,14 @@ bool DallasTemperature::hasAlarm(const uint8_t* deviceAddress) {
 	ScratchPad scratchPad;
 	if (isConnected(deviceAddress, scratchPad)) {
 
-		char temp = calculateTemperature(deviceAddress, scratchPad) >> 7;
+		int8_t temp = calculateTemperature(deviceAddress, scratchPad) >> 7;
 
 		// check low alarm
-		if (temp <= (char) scratchPad[LOW_ALARM_TEMP])
+		if (temp <= (int8_t) scratchPad[LOW_ALARM_TEMP])
 			return true;
 
 		// check high alarm
-		if (temp >= (char) scratchPad[HIGH_ALARM_TEMP])
+		if (temp >= (int8_t) scratchPad[HIGH_ALARM_TEMP])
 			return true;
 	}
 

DallasTemperature.h

@@ -1,7 +1,7 @@
 #ifndef DallasTemperature_h
 #define DallasTemperature_h
 
-#define DALLASTEMPLIBVERSION "3.7.7" // To be deprecated
+#define DALLASTEMPLIBVERSION "3.7.8" // To be deprecated
 
 // This library is free software; you can redistribute it and/or
 // modify it under the terms of the GNU Lesser General Public
@@ -135,20 +135,20 @@ class DallasTemperature {
 	typedef void AlarmHandler(const uint8_t*);
 
 	// sets the high alarm temperature for a device
-	// accepts a char.  valid range is -55C - 125C
-	void setHighAlarmTemp(const uint8_t*, char);
+	// accepts a int8_t.  valid range is -55C - 125C
+	void setHighAlarmTemp(const uint8_t*, int8_t);
 
 	// sets the low alarm temperature for a device
-	// accepts a char.  valid range is -55C - 125C
-	void setLowAlarmTemp(const uint8_t*, char);
+	// accepts a int8_t.  valid range is -55C - 125C
+	void setLowAlarmTemp(const uint8_t*, int8_t);
 
-	// returns a signed char with the current high alarm temperature for a device
+	// returns a int8_t with the current high alarm temperature for a device
 	// in the range -55C - 125C
-	char getHighAlarmTemp(const uint8_t*);
+	int8_t getHighAlarmTemp(const uint8_t*);
 
-	// returns a signed char with the current low alarm temperature for a device
+	// returns a int8_t with the current low alarm temperature for a device
 	// in the range -55C - 125C
-	char getLowAlarmTemp(const uint8_t*);
+	int8_t getLowAlarmTemp(const uint8_t*);
 
 	// resets internal variables used for the alarm search
 	void resetAlarmSearch(void);
@@ -239,7 +239,7 @@ class DallasTemperature {
 
 	// required for alarmSearch
 	uint8_t alarmSearchAddress[8];
-	char alarmSearchJunction;
+	int8_t alarmSearchJunction;
 	uint8_t alarmSearchExhausted;
 
 	// the alarm handler function pointer

library.json

@@ -34,7 +34,7 @@
     "authors": "Paul Stoffregen",
     "frameworks": "arduino"
   },
-  "version": "3.7.7",
+  "version": "3.7.8",
   "frameworks": "arduino",
   "platforms": "*"
 }

library.properties

@@ -1,5 +1,5 @@
 name=DallasTemperature
-version=3.7.7
+version=3.7.8
 author=Miles Burton <miles@mnetcs.com>, Tim Newsome <nuisance@casualhacker.net>, Guil Barros <gfbarros@bappos.com>, Rob Tillaart <rob.tillaart@gmail.com>
 maintainer=Miles Burton <miles@mnetcs.com>
 sentence=Arduino Library for Dallas Temperature ICs