Skip to content

Commit 01926a0

Browse files
committed
display JSON error message on failed notebook load
if there is one (escaped for safety).
1 parent 7643236 commit 01926a0

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

IPython/html/static/notebook/js/notebook.js

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2288,7 +2288,11 @@ define([
22882288
this.events.trigger('notebook_load_failed.Notebook', [xhr, status, error]);
22892289
var msg;
22902290
if (xhr.status === 400) {
2291-
msg = error;
2291+
if (xhr.responseJSON && xhr.responseJSON.message) {
2292+
msg = escape(xhr.responseJSON.message);
2293+
} else {
2294+
msg = escape(error);
2295+
}
22922296
} else if (xhr.status === 500) {
22932297
msg = "An unknown error occurred while loading this notebook. " +
22942298
"This version can load notebook formats " +
@@ -2567,10 +2571,10 @@ define([
25672571
* @method delete_checkpoint_error
25682572
* @param {jqXHR} xhr jQuery Ajax object
25692573
* @param {String} status Description of response status
2570-
* @param {String} error_msg HTTP error message
2574+
* @param {String} error HTTP error message
25712575
*/
2572-
Notebook.prototype.delete_checkpoint_error = function (xhr, status, error_msg) {
2573-
this.events.trigger('checkpoint_delete_failed.Notebook');
2576+
Notebook.prototype.delete_checkpoint_error = function (xhr, status, error) {
2577+
this.events.trigger('checkpoint_delete_failed.Notebook', [xhr, status, error]);
25742578
};
25752579

25762580

0 commit comments

Comments
 (0)