Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove gap prop from Box component and its usage across components & stories #603

Closed
chaitanyadeorukhkar opened this issue Aug 3, 2022 · 3 comments
Closed

Remove gap prop from Box component and its usage across components & stories #603

chaitanyadeorukhkar opened this issue Aug 3, 2022 · 3 comments
Labels
bug

Comments

@chaitanyadeorukhkar
Copy link
Collaborator

Since there is no support for gap on React Native yet, adding support for gap on Box would lead to UI breakage on native components. We have already used gap with Box at multiple places and we need to remove those instances and replace them with other appropriate spacings.
@chaitanyadeorukhkar
Copy link
Collaborator Author

@anuraghazra do you want to take this up since it could have some impact on Checkbox?

@anuraghazra
Copy link
Member

Yes I'll fix this.

This was referenced Oct 21, 2022
Closed
Merged
@anuraghazra
Copy link
Member

Fixed in #758

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chaitanyadeorukhkar @anuraghazra