Skip to content

Bump version to 1.9.4 #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 4, 2018
Merged

Bump version to 1.9.4 #459

merged 2 commits into from
Feb 4, 2018

Conversation

a3f
Copy link
Contributor

@a3f a3f commented Feb 4, 2018

No description provided.

@raysan5
Copy link
Owner

raysan5 commented Feb 4, 2018

Ouch! I miss that! Should I launch a new release? I can cancel previous one...

@a3f
Copy link
Contributor Author

a3f commented Feb 4, 2018

I think that would be the best, to avoid confusion as this release has the version embedded in the libraries and the pkg-config files. I am in favor of a 1.9.4-dev (To avoid breaking people who have pulled 1.9.3-dev already…), Should I push a 1.9.4?

@raysan5
Copy link
Owner

raysan5 commented Feb 4, 2018

Should I push a 1.9.4?

Sure. I'm also changing it in raylib internals and integrating to master again.

a3f added 2 commits February 4, 2018 13:35
While nice to test, this would mean that the tagged release will depend
on GLFW as well… Therefore disable it for now.
@raysan5
Copy link
Owner

raysan5 commented Feb 4, 2018

Just as a note, we should find a way to automatically pick version from somewhere instead of changing version number text manually inside raylib.

@a3f a3f changed the title Bump version to 1.9.3 Bump version to 1.9.4 Feb 4, 2018
@a3f
Copy link
Contributor Author

a3f commented Feb 4, 2018

Suggestion: Check if git is available and use git describe --tags. This returns 1.9.3-dev on master. If there are commits since the tag, it appends a commit id after the tag, e.g. 1.9.3-dev-1-g0edaecf. Pass it as RAYLIB_VERSION macro to build process. If there's no git, we'll have to use a hardcoded value as fallback.

@raysan5 raysan5 merged commit 327aec9 into raysan5:develop Feb 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants