[examples] Fix PBR and Shadowmap example shaders for GLSL 1.20 #4167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove presicion mediump float because it is for GLES, and not desktop GL
CDM15y
changed the title
|
I am going to test the other shaders, and try to port the GLSL 330 ones. |
also suffers the same problem as pbr.fs
CDM15y
changed the title
|
Fixed shadowmap.fs |
|
EDIT: Sorry, I missunderstood the comment. Thanks for the improvement! |
|
No problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed presicion mediump float because it is for GLES, and not desktop GL.
also removed 'in' that are in a multitude of lines, because someone when porting it didn't remove it and didn't test it.
Tested on
Mesa Mobile Intel® GM45 Express Chipset (CTG) (0x2a42)it works.