-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] On limit exceeded, response is not given #28
Comments
Repro updated, bug still present with last version of bun + elysia + elysia-rate-limit |
Sorry, I got super busy with my work this week. I've confirmed that my rate-limit plugin already passed rate-limited response away from plugin properly. I found this empty response is quickly solved after remove |
Also related to #18 |
any update @SaltyAom ? |
He's on holiday (me too). He'll be back next week. |
any update @SaltyAom ? |
1.1 just recently launched, can you try to confirm does this solves a problem? |
No @rayriffy error still present :/ (I have updated the repro) |
Should have been fixed on elysiajs/elysia@ff73f80, published on 1.0.16. Please update and let me know if it works. |
Thanks I can confirm is working I close the issue ! |
Before open the issue
node_modules/
,bun.lockb
, and do a clean installation.Describe the bug
When a user reach the limit, the response is never given
To Reproduce
Please provide a small reproduction project if possible. Steps to reproduce the behavior:
bun i && docker-compose up -d && cp .env.example .env && bun dev
http://localhost:3000/swagger
and execute/auth/login
with random password and email more than 6 timesExpected behavior
A clear and concise description of what you expected to happen.
Return response 429
Environments
171139393022.04~331756a SMP PREEMPT_DYNAMIC Mon M x86_64 x86_64 x86_64 GNU/LinuxScreenshots
Additional Context
For me I have checked source code, nothing seems strange or with bugs. So maybe elysia directly ?
The text was updated successfully, but these errors were encountered: