Fix void elements #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Upgrade and actually use the `void-elements` module that this package depends on. - Don't assume it's a void element just because `/` is at the end of the tag, actually use the lookup.
|
Not really sure why the tests are failing, but it's not because of these changes... |
rayd
added a commit
that referenced
this pull request
Jul 24, 2017
|
Sorry for the huge delay on these PRs your submitted @MarkCarver! I appreciate the work you put in! Made a couple tweaks to things based on some submitted issues and reading over the HTML spec. For this one, it seemed like we ought to support handling tags that declare themselves as self-closing as "void elements" in the parser, since the spec allows one to declare "foreign elements" that can be self-closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
void-elementsmodule that this package depends on./is at the end of the tag, actually use the lookup.