Catch when we're dealing with a comment and just ignore it.

rayd · Jun 27, 2016 · 3b4e3c1 · 3b4e3c1
1 parent 7caf311
commit 3b4e3c1
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/lib/parse.js b/lib/parse.js
@@ -22,6 +22,10 @@ module.exports = function parse(html, options) {
                 inComponent = false;
             }
         }
+        // check if this is a comment tag. if so, just return.
+        if (tag.indexOf('<!--') === 0) {
+            return;
+        }
         var isOpen = tag.charAt(1) !== '/';
         var start = index + tag.length;
         var nextChar = html.charAt(start);

diff --git a/test/parse.js b/test/parse.js
@@ -366,6 +366,18 @@ test('parse', function (t) {
             { type: 'text', content: 'There' }
         ]
     }], 'should remove text nodes that are nothing but whitespace');
+
+    html = '<!--\n\t<style type="text/css">\n\t\t.header {\n\t\t\tfont-size: 14px;\n\t\t}\n\t</style>\n\n-->\n<div>Hi</div>';
+    parsed = HTML.parse(html);
+    t.deepEqual(parsed, [{
+        type: 'tag',
+        name: 'div',
+        attrs: {},
+        voidElement: false,
+        children: [
+            { type: 'text', content: 'Hi'}
+        ]
+    }], 'should ignore HTML comments');
     t.end();
 });