unify plasma_seal paths #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcmoritz
reviewed
Dec 8, 2016
| if (state->db) { | ||
| LOG_DEBUG("Publishing to object table from DB client %d.", | ||
| get_client_id(conn->manager_state->db)); | ||
| /* TODO(swang): Log the error if we fail to add the object, and possibly |
There was a problem hiding this comment.
The indentation of the comment got messed up
There was a problem hiding this comment.
Actually, can you get rid of the LOG_DEBUG statement? It looks like we had a bug there because get_client_id doesn't return an int, so that statement won't work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plasma seal request now goes only to the store, which triggers the manager reactively to add the object to the Redis object table.