Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test-multi-node #9453

Merged
merged 1 commit into from
Jul 14, 2020
Merged

Fix test-multi-node #9453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions python/ray/state.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ def object_table(self, object_ref=None):
for i in range(len(object_table)):
object_location_info = gcs_utils.ObjectLocationInfo.FromString(
object_table[i])
results[binary_to_hex(object_location_info.object_ref)] = \
results[binary_to_hex(object_location_info.object_id)] = \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these should actually get changed to object_ref

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the protobuf, it seems to be just bytes type, which looks like just the ID? Isn't objectRef indicating the whole object? (I might misunderstand this)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, right, this seems fine then.

self._gen_object_info(object_location_info)
return results

Expand All @@ -198,7 +198,7 @@ def _gen_object_info(self, object_location_info):

object_info = {
"ObjectRef": ray.utils.binary_to_hex(
object_location_info.object_ref),
object_location_info.object_id),
"Locations": locations,
}
return object_info
Expand Down
1 change: 1 addition & 0 deletions python/ray/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ def run_string_as_driver(driver_script):
with proc:
output = proc.communicate(driver_script.encode("ascii"))[0]
if proc.returncode:
print(ray.utils.decode(output))
raise subprocess.CalledProcessError(proc.returncode, proc.args,
output, proc.stderr)
out = ray.utils.decode(output)
Expand Down