-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make more tests run on Windows #8553
Conversation
Can one of the admins verify this patch? |
Test PASSed. |
Hmm I'll rerun his, confused why the commit tests didn't pass here when they passed for mine... please don't merge yet, sorry. |
Test PASSed. |
Test PASSed. |
Test PASSed. |
6262a72
to
1a6b4c7
Compare
Test PASSed. |
Test PASSed. |
Test PASSed. |
Test PASSed. |
Test FAILed. |
Test FAILed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Why are these changes needed?
We make more tests run on Windows for Python 3.8.2.
For now we do this via direct invocation of
pytest
.Later we'll fix some more issues to hopefully use
bazel test
and support earlier versions of Python.Related issue number
#631
Checks
scripts/format.sh
to lint the changes in this PR.