handling partial/interrupted I/O #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated read_bytes and write_bytes to handle EINTR and changed the flow a bit.
EINTR is induced when a process is interrupted by a signal while doing I/O. It is not uncommon in asynchronous, event-driven code with callbacks. Different *Nix systems may handle EINTR differently, some automatically restart the syscall, some don't. It is best to handle it in all cases and manually restart the syscall, while accounting for the partial read/write.
Plasma send/receive were updated to support partial fd reads/writes, in lieu of treating them as failed I/O.