Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GCS]refactor the GCS Client Task Interface #6556

Merged
merged 3 commits into from
Dec 23, 2019

Conversation

micafan
Copy link
Contributor

@micafan micafan commented Dec 20, 2019

Refactoring the GCS Client Task Interface .
Only expose Ray-specific semantics (e.g., AsyncSubscribe, AsyncUpdate, etc), and hide the implementation details about the backed storage.

Create this PR because the old PR #5515 which is merged and reverted (reverted because UT failed and the wrong CHECK in code).

Why are these changes needed?

Related issue number

Checks

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@jovany-wang jovany-wang force-pushed the add_task_state_accessor_ci branch from 601652f to 52138a2 Compare December 20, 2019 07:24
@ericl
Copy link
Contributor

ericl commented Dec 20, 2019

It's a bit unfortunate we have to add interfaces for the task table, which is only used in a very minimal way at this point but is quite complex. Would it be bad to leave it out? Once we enable the new scheduler it will be completely unused.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/19897/
Test FAILed.

@micafan
Copy link
Contributor Author

micafan commented Dec 20, 2019

It's a bit unfortunate we have to add interfaces for the task table, which is only used in a very minimal way at this point but is quite complex. Would it be bad to leave it out? Once we enable the new scheduler it will be completely unused.

How about add the new interface to TaskInfoAccessor too by then? I think expose TaskTable is not safe, some people might use it instead of TaskInfoAccessor.

@ericl
Copy link
Contributor

ericl commented Dec 20, 2019

It shouldn't matter, as the code is deprecated and will be removed as soon as the new scheduler is ready. Direct calls doesn't use it.

How about we freeze changes to the task lineage and lease management until it is removed?

@micafan
Copy link
Contributor Author

micafan commented Dec 20, 2019

It doesn't matter, as the code is deprecated and will be removed as soon as the new scheduler is ready.

How about we freeze changes to the task lineage and lease management until it is removed?

If you really don't want to add new interface to TaskInfoAccessor, then we can expose the TaskTable for temporary. I don't think freeze this PR is a good idea, because it is not clear how long the PR is frozen.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/19902/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/19903/
Test FAILed.

@micafan micafan changed the title [Don't review or merge] trigger ci [trigger ci][GCS]refactor the GCS Client Task Interface Dec 22, 2019
@raulchen
Copy link
Contributor

Hi @ericl, we'd like to merge this PR first to unblock other work on GCS Service.
The changes to table table and lineage cache are pretty straightforward. We simply wrap old task_table code with new TaskInfoAccessor interface.
When we enable the new scheduler, it should be very easy to remove the task table.
Also, this PR refactors code about the new gcs client as well.
Please let us know if you still have concerns. Thanks.

@raulchen
Copy link
Contributor

BTW, for the short term, I think we still need task table to store actor creation task spec.

@micafan
Copy link
Contributor Author

micafan commented Dec 23, 2019

@ericl Could you take a look at the auto scaling test failed issue 6582 .

@raulchen raulchen changed the title [trigger ci][GCS]refactor the GCS Client Task Interface [GCS]refactor the GCS Client Task Interface Dec 23, 2019
@raulchen
Copy link
Contributor

Test failure should be irrelevant.

@raulchen raulchen merged commit 84d3d4b into ray-project:master Dec 23, 2019
@raulchen raulchen deleted the add_task_state_accessor_ci branch December 23, 2019 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants