-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GCS]refactor the GCS Client Task Interface #6556
[GCS]refactor the GCS Client Task Interface #6556
Conversation
Can one of the admins verify this patch? |
601652f
to
52138a2
Compare
It's a bit unfortunate we have to add interfaces for the task table, which is only used in a very minimal way at this point but is quite complex. Would it be bad to leave it out? Once we enable the new scheduler it will be completely unused. |
Test FAILed. |
How about add the new interface to TaskInfoAccessor too by then? I think expose TaskTable is not safe, some people might use it instead of TaskInfoAccessor. |
It shouldn't matter, as the code is deprecated and will be removed as soon as the new scheduler is ready. Direct calls doesn't use it. How about we freeze changes to the task lineage and lease management until it is removed? |
If you really don't want to add new interface to TaskInfoAccessor, then we can expose the TaskTable for temporary. I don't think freeze this PR is a good idea, because it is not clear how long the PR is frozen. |
Test FAILed. |
Test FAILed. |
Hi @ericl, we'd like to merge this PR first to unblock other work on GCS Service. |
BTW, for the short term, I think we still need task table to store actor creation task spec. |
Test failure should be irrelevant. |
Refactoring the GCS Client Task Interface .
Only expose Ray-specific semantics (e.g., AsyncSubscribe, AsyncUpdate, etc), and hide the implementation details about the backed storage.
Create this PR because the old PR #5515 which is merged and reverted (reverted because UT failed and the wrong CHECK in code).
Why are these changes needed?
Related issue number
Checks
scripts/format.sh
to lint the changes in this PR.