-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GCS]Add abstract interface of actor to GCS Client #6269
[GCS]Add abstract interface of actor to GCS Client #6269
Conversation
Can one of the admins verify this patch? |
Test FAILed. |
Test PASSed. |
Test FAILed. |
Test PASSed. |
Test FAILed. |
Test FAILed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a few more nits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah sorry, meant to approve....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding the file structure, it seems that we'll have 5 files (x_info_accessor.h
, redis_x_info_accessor.h/cc
, and service_based_x_info_accessor.h/cc
). That's a bit too complicated. What about just put everything in 2 files x_info_accessor.h/cc
?
Test PASSed. |
Test PASSed. |
Test PASSed. |
Test FAILed. |
Test FAILed. |
Add abstract interface for reading or writing or subscribing actors to GCS Client. Through the abstract interface, GCS can be extended to support other storage systems.
Related issue number
Closes #5058
Checks
scripts/format.sh
to lint the changes in this PR.