Skip to content

Conversation

edoakes
Copy link
Collaborator

@edoakes edoakes commented Oct 10, 2025

The test times out frequently in CI.

Before this change, the test took ~40s to run on my laptop. After the change, the test took ~15s to run on my laptop.

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@edoakes edoakes requested a review from a team as a code owner October 10, 2025 15:10
@edoakes edoakes added the go add ONLY when ready to merge, run all tests label Oct 10, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to reduce the runtime of test_transient_error_retry to prevent CI timeouts. The changes achieve this by tuning RAY_actor_scheduling_queue_max_reorder_wait_seconds to a lower value. Additionally, the test is simplified by removing an unnecessary resource constraint (resources={"head": 1}) for the actor and the worker node. The changes look good and effectively address the performance issue with the test. I have one minor suggestion to add a comment explaining the purpose of the environment variable for better maintainability.

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@ray-gardener ray-gardener bot added the core Issues that should be addressed in Ray Core label Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Issues that should be addressed in Ray Core go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants