Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed link in tune that was not working #5331

Merged
merged 3 commits into from
Aug 1, 2019
Merged

Fixed link in tune that was not working #5331

merged 3 commits into from
Aug 1, 2019

Conversation

lukasfolle
Copy link
Contributor

What do these changes do?

Fixed link leading to 404 page.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/15834/
Test PASSed.

richardliaw
richardliaw requested changes Jul 31, 2019
View reviewed changes
Copy link
Contributor

@richardliaw richardliaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! I think this is pointing to the wrong tutorial intended still.

@lukasfolle @richardliaw
Update to correct exercise
d3597f0 
Co-Authored-By: Richard Liaw <rliaw@berkeley.edu>
@lukasfolle
Copy link
Contributor Author

You are right!

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/15843/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/15845/
Test PASSed.

@richardliaw richardliaw merged commit 0391050 into ray-project:master Aug 1, 2019
@lukasfolle
Copy link
Contributor Author

The error still persists on the doc page https://ray.readthedocs.io/en/latest/tune.html
Can someone also correct it there?

@lukasfolle lukasfolle deleted the lukas-fix branch August 5, 2019 07:16
edoakes pushed a commit to edoakes/ray that referenced this pull request Aug 9, 2019
@lukasfolle @edoakes
Fixed link in tune that was not working (ray-project#5331)
e28af6d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardliaw richardliaw richardliaw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukasfolle @AmplabJenkins @richardliaw