[tune] support nested dictionaries for CSVLogger #5295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardliaw
approved these changes
Jul 27, 2019
richardliaw
reviewed
Jul 27, 2019
| tmp = result.copy() | ||
| if "config" in tmp: | ||
| del tmp["config"] | ||
| result = flatten_dict(tmp, delimiter="/") |
There was a problem hiding this comment.
cc @hartikainen this may affect viskit visualization?
There was a problem hiding this comment.
I think this should be fine. In softlearning, I actually flatten all the dicts in a similar way before returning the results.
|
Test FAILed. |
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Aug 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue number
Closes #5294
Linter
scripts/format.shto lint the changes in this PR.