Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ClientTableData to GcsNodeInfo #5251

Merged
merged 9 commits into from
Jul 30, 2019
Merged

Rename ClientTableData to GcsNodeInfo #5251

merged 9 commits into from
Jul 30, 2019

Conversation

micafan
Copy link
Contributor

@micafan micafan commented Jul 23, 2019 •
edited
Loading

What do these changes do?

Rename ClientTableData to GcsNodeInfo since ClientTableData is used to describe node information in GCS.

Related issue number

Linter

  • I've run scripts/format.sh to lint the changes in this PR.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/15586/
Test FAILed.

jovany-wang
jovany-wang reviewed Jul 23, 2019
View reviewed changes
src/ray/raylet/node_manager.h Show resolved Hide resolved
src/ray/raylet/raylet.h Show resolved Hide resolved
src/ray/protobuf/gcs.proto
// The IP address of the client's node manager.
message GcsNodeInfo {
// State of a node.
enum GcsNodeState {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NodeState ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-Perf-Integration-PRB/1824/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-Perf-Integration-PRB/1825/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/15651/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/15652/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/15677/
Test PASSed.

@raulchen
Copy link
Contributor

CI failure should be related https://travis-ci.com/ray-project/ray/builds/120816886

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/15707/
Test FAILed.

raulchen
raulchen approved these changes Jul 28, 2019
View reviewed changes
Copy link
Contributor

@raulchen raulchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you fix the linter failure (https://travis-ci.com/ray-project/ray/jobs/220151982)? then we can merge it.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/15726/
Test PASSed.

@raulchen
Copy link
Contributor

https://travis-ci.com/ray-project/ray/jobs/220220236
This test failure is related.

@micafan
Copy link
Contributor Author

micafan commented Jul 30, 2019 •
edited
Loading

https://travis-ci.com/ray-project/ray/jobs/220220236
This test failure is related.

Maybe not caused by this PR. It's reproduced in jovany-wang's PR. My development environment has a problem that has not been resolved, so jovany-wang is tracking it now.

@raulchen
Copy link
Contributor

ok, that test is failing on master as well. I'll merge this PR.

@raulchen raulchen merged commit b3bcf59 into ray-project:master Jul 30, 2019
@raulchen raulchen deleted the rename_client_table_data branch July 30, 2019 03:25
edoakes pushed a commit to edoakes/ray that referenced this pull request Aug 9, 2019
@micafan @edoakes
Rename ClientTableData to GcsNodeInfo (ray-project#5251)
6e722e2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jovany-wang jovany-wang jovany-wang left review comments

@raulchen raulchen raulchen approved these changes

@ericl ericl ericl approved these changes

@stephanie-wang stephanie-wang Awaiting requested review from stephanie-wang

@robertnishihara robertnishihara Awaiting requested review from robertnishihara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@micafan @AmplabJenkins @raulchen @ericl @jovany-wang