Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build-docker.sh bug #515

Merged
merged 2 commits into from
May 7, 2017
Merged

Conversation

feynmanliang
Copy link
Contributor

@feynmanliang feynmanliang commented May 5, 2017

Builds the examplescontainer even if --output-sha is not passed in

The [documentation](http://ray.readthedocs.io/en/latest/install-on-docker.html#build-docker-images)  says that the `examples` image is built by `build-docker.sh` script.
@feynmanliang feynmanliang reopened this May 5, 2017
@feynmanliang feynmanliang changed the title Build examples by default Fix build-docker.sh bug May 5, 2017
@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@robertnishihara
Copy link
Collaborator

ok to test

@robertnishihara
Copy link
Collaborator

cc @jssmith

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/682/
Test PASSed.

@robertnishihara robertnishihara merged commit 7825aed into ray-project:master May 7, 2017
@feynmanliang feynmanliang deleted the patch-1 branch May 7, 2017 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants