Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc][build] build doc with python 3.12 #46772

Merged
merged 2 commits into from
Jul 24, 2024
Merged

[doc][build] build doc with python 3.12 #46772

merged 2 commits into from
Jul 24, 2024

Conversation

can-anyscale
Copy link
Collaborator

@can-anyscale can-anyscale commented Jul 24, 2024

Build doc in CI with python 3.12 to align with what we recommend as the local dev build environment.

I tested the build

s3://ray-ci-results/doc_build/44b1106a3f4470d359009adf2dc3bebc4af79409.tgz

and the pickfile has more files that we want

Test:

  • CI

@can-anyscale can-anyscale force-pushed the candb04 branch 4 times, most recently from 44b1106 to 0cb5304 Compare July 24, 2024 05:27
@can-anyscale can-anyscale marked this pull request as ready for review July 24, 2024 05:28
@can-anyscale can-anyscale requested a review from a team as a code owner July 24, 2024 05:28
@can-anyscale can-anyscale requested review from khluu and aslonnie July 24, 2024 05:28
@@ -1,4 +1,4 @@
ARG DOCKER_IMAGE_BASE_BUILD=cr.ray.io/rayproject/oss-ci-base_build
ARG DOCKER_IMAGE_BASE_BUILD=cr.ray.io/rayproject/oss-ci-base_build-py3.12
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is this built btw?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@can-anyscale can-anyscale enabled auto-merge (squash) July 24, 2024 05:47
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Jul 24, 2024
@can-anyscale can-anyscale disabled auto-merge July 24, 2024 05:49
@can-anyscale can-anyscale enabled auto-merge (squash) July 24, 2024 05:53
@github-actions github-actions bot disabled auto-merge July 24, 2024 06:17
@can-anyscale can-anyscale force-pushed the candb04 branch 2 times, most recently from 4c2435f to fa97eea Compare July 24, 2024 13:32
@can-anyscale can-anyscale enabled auto-merge (squash) July 24, 2024 13:32
Signed-off-by: can <can@anyscale.com>
Signed-off-by: can <can@anyscale.com>
@can-anyscale can-anyscale changed the base branch from master to can-fixopenssl July 24, 2024 14:08
@github-actions github-actions bot disabled auto-merge July 24, 2024 14:08
Base automatically changed from can-fixopenssl to master July 24, 2024 16:10
@can-anyscale can-anyscale merged commit 9cd160d into master Jul 24, 2024
5 checks passed
@can-anyscale can-anyscale deleted the candb04 branch July 24, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants