Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sleep for half a second at exit in order to avoid losing log messages… #4254

Merged
merged 2 commits into from
Mar 5, 2019
Merged

Sleep for half a second at exit in order to avoid losing log messages… #4254

merged 2 commits into from
Mar 5, 2019

Conversation

robertnishihara
Copy link
Collaborator

… from the print_logs thread.

This addresses the remaining issue from #4082 (at least in most cases)

ericl
ericl reviewed Mar 5, 2019
View reviewed changes
Copy link
Contributor

@ericl ericl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Since it's easy to regress this, could we add a test?

@robertnishihara
Copy link
Collaborator Author

Added a test. I confirmed that it fails before this PR.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12542/
Test FAILed.

@pcmoritz
Copy link
Contributor

pcmoritz commented Mar 5, 2019

Test failures are unrelated to this PR, testTrialNoSave is fixed in #4262 and the wait one was introduced in 8b871af

@pcmoritz pcmoritz merged commit fa8c07d into ray-project:master Mar 5, 2019
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12543/
Test FAILed.

@robertnishihara robertnishihara mentioned this pull request Mar 12, 2019
Closed
@robertnishihara robertnishihara deleted the sleepatexit branch January 7, 2020 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericl ericl ericl left review comments

@pcmoritz pcmoritz pcmoritz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@robertnishihara @AmplabJenkins @pcmoritz @ericl