Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "ray timeline" command to auto-dump Chrome trace for the current Ray instance #4239

Merged
merged 5 commits into from
Mar 6, 2019

Conversation

ericl
Copy link
Contributor

@ericl ericl commented Mar 3, 2019

No description provided.

@robertnishihara
Copy link
Collaborator

I just ran this on my laptop (MacOS) and saw

$ ray timeline
Traceback (most recent call last):
  File "/Users/rnishihara/anaconda3/lib/python3.6/site-packages/psutil/_psosx.py", line 362, in catch_zombie
    yield
  File "/Users/rnishihara/anaconda3/lib/python3.6/site-packages/psutil/_psosx.py", line 426, in cmdline
    return cext.proc_cmdline(self.pid)
ProcessLookupError: [Errno 3] No such process

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Users/rnishihara/anaconda3/bin/ray", line 11, in <module>
    load_entry_point('ray', 'console_scripts', 'ray')()
  File "/Users/rnishihara/ray_scratch/ray/python/ray/scripts/scripts.py", line 761, in main
    return cli()
  File "/Users/rnishihara/anaconda3/lib/python3.6/site-packages/click/core.py", line 764, in __call__
    return self.main(*args, **kwargs)
  File "/Users/rnishihara/anaconda3/lib/python3.6/site-packages/click/core.py", line 717, in main
    rv = self.invoke(ctx)
  File "/Users/rnishihara/anaconda3/lib/python3.6/site-packages/click/core.py", line 1137, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/Users/rnishihara/anaconda3/lib/python3.6/site-packages/click/core.py", line 956, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/Users/rnishihara/anaconda3/lib/python3.6/site-packages/click/core.py", line 555, in invoke
    return callback(*args, **kwargs)
  File "/Users/rnishihara/ray_scratch/ray/python/ray/scripts/scripts.py", line 716, in timeline
    for arglist in proc.cmdline():
  File "/Users/rnishihara/anaconda3/lib/python3.6/site-packages/psutil/__init__.py", line 663, in cmdline
    return self._proc.cmdline()
  File "/Users/rnishihara/anaconda3/lib/python3.6/site-packages/psutil/_psosx.py", line 342, in wrapper
    return fun(self, *args, **kwargs)
  File "/Users/rnishihara/anaconda3/lib/python3.6/site-packages/psutil/_psosx.py", line 426, in cmdline
    return cext.proc_cmdline(self.pid)
  File "/Users/rnishihara/anaconda3/lib/python3.6/contextlib.py", line 99, in __exit__
    self.gen.throw(type, value, traceback)
  File "/Users/rnishihara/anaconda3/lib/python3.6/site-packages/psutil/_psosx.py", line 375, in catch_zombie
    raise AccessDenied(proc.pid, proc._name)
psutil._exceptions.AccessDenied: psutil.AccessDenied (pid=35463)

@ericl
Copy link
Contributor Author

ericl commented Mar 4, 2019

Ok, I think it's fixed now to ignore that as well.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12516/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12520/
Test FAILed.

@robertnishihara robertnishihara merged commit 78ad9c4 into ray-project:master Mar 6, 2019
@robertnishihara robertnishihara deleted the ray-timeline branch March 6, 2019 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants