If no local scheduler receives actor notification, retry. #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertnishihara
commented
Mar 24, 2017
| for _ in range(num_retries): | ||
| num_recipients = worker.redis_client.publish( | ||
| "actor_notifications", actor_id.id() + local_scheduler_id) | ||
| if num_recipients == 1: |
There was a problem hiding this comment.
This doesn't quite work because all of the local schedulers in the cluster will receive this publish message.
We could separate this into two publish message:
- One targeted at the local scheduler that is supposed to create the actor.
- One targeted at all local schedulers to notify them of the existence of a new actor.
|
Merged build finished. Test PASSed. |
|
Test PASSed. |
|
Closing for now because this fix doesn't quite work. However, the underlying problem remains, so some fix will be needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may address #362.