-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pyarrow version #3760
Fix pyarrow version #3760
Changes from all commits
4621a7d
6f75684
9fc8a42
216a1bb
331e594
70f6462
8bcf808
93c0445
7995297
33819e8
7f187b1
68961a8
d663993
b4b015b
7b685d4
ab01e21
7f9d107
62460b5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||
---|---|---|---|---|
|
@@ -118,6 +118,7 @@ if ("${CMAKE_RAY_LANG_PYTHON}" STREQUAL "YES") | |||
|
||||
# PYARROW_PARALLEL= , so it will add -j to pyarrow build | ||||
set(pyarrow_ENV | ||||
"SETUPTOOLS_SCM_PRETEND_VERSION=0.11.1-RAY" | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. So does this need to be updated every time we update arrow? If so, we should include a prominent comment in
explaining that people need to update this code. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. fixed |
||||
"PKG_CONFIG_PATH=${ARROW_LIBRARY_DIR}/pkgconfig" | ||||
"PYARROW_WITH_PLASMA=1" | ||||
"PYARROW_WITH_TENSORFLOW=1" | ||||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -67,7 +67,7 @@ for ((i=0; i<${#PY_VERSIONS[@]}; ++i)); do | |
$PIP_CMD install --upgrade setuptools | ||
# Install setuptools_scm because otherwise when building the wheel for | ||
# Python 3.6, we see an error. | ||
$PIP_CMD install -q setuptools_scm==2.1.0 | ||
$PIP_CMD install -q setuptools_scm==3.1.0 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What was the issue? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. On macos python 2.7 it didn't support SETUPTOOLS_SCM_PRETEND_VERSION properly (the version was just None) |
||
# Fix the numpy version because this will be the oldest numpy version we can | ||
# support. | ||
$PIP_CMD install -q numpy==$NUMPY_VERSION cython==0.29.0 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you say what this does and what the issue was?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it caused the linker error I posted in #3744. There was a function in boost regex that used std::string and that needs the old ABI.