Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically indent tune logger params #3399

Merged
merged 1 commit into from
Nov 29, 2018
Merged

Automatically indent tune logger params #3399

merged 1 commit into from
Nov 29, 2018

Conversation

hartikainen
Copy link
Contributor

@hartikainen hartikainen commented Nov 25, 2018 •
edited
Loading

Adds indent=2 to tune logger params dump such that the params file gets automatically formatted.

Closes #3398

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/9583/
Test FAILed.

ericl
ericl approved these changes Nov 25, 2018
View reviewed changes
Copy link
Contributor

@ericl ericl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I imagine this json.loads() fine still so probably will pass tests.

@ericl
Copy link
Contributor

ericl commented Nov 26, 2018

jenkins retest this please

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/9595/
Test FAILed.

@richardliaw
Copy link
Contributor

jenkins retest this please

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/9652/
Test FAILed.

@ericl ericl merged commit 7e319db into ray-project:master Nov 29, 2018
@hartikainen hartikainen deleted the tweak/indent-tune-logger-params-json branch December 5, 2018 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericl ericl ericl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hartikainen @AmplabJenkins @ericl @richardliaw