Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incompatibility with most recent version of Redis. #3379

Merged
merged 3 commits into from
Nov 25, 2018
Merged

Fix incompatibility with most recent version of Redis. #3379

merged 3 commits into from
Nov 25, 2018

Conversation

robertnishihara
Copy link
Collaborator

This fixes #3334. Basically, anywhere that we're passing a boolean or None into a Redis command, we need to first convert it to a string.

@robertnishihara
Copy link
Collaborator Author

cc @lewisbelcher

robertnishihara
robertnishihara commented Nov 22, 2018
View reviewed changes
python/ray/worker.py
@@ -713,7 +713,7 @@ def run_function_on_all_workers(self, function,
"driver_id": self.task_driver_id.id(),
"function_id": function_to_run_id,
"function": pickled_function,
"run_on_other_drivers": run_on_other_drivers
"run_on_other_drivers": str(run_on_other_drivers)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run_on_other_drivers is a bool

robertnishihara
robertnishihara commented Nov 22, 2018
View reviewed changes
python/ray/worker.py
@@ -2027,7 +2022,6 @@ def connect(info,
worker_dict = {
"node_ip_address": worker.node_ip_address,
"plasma_store_socket": info["store_socket_name"],
"local_scheduler_socket": info["local_scheduler_socket_name"]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these values were None and weren't being used anyway

@robertnishihara robertnishihara mentioned this pull request Nov 22, 2018
Closed
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/9522/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/9525/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/9532/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/9575/
Test FAILed.

devin-petersohn
devin-petersohn approved these changes Nov 25, 2018
View reviewed changes
Copy link
Member

@devin-petersohn devin-petersohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Tested locally on 2.10.6 and it works, thanks!

@devin-petersohn devin-petersohn merged commit 3856533 into ray-project:master Nov 25, 2018
@devin-petersohn devin-petersohn mentioned this pull request Nov 25, 2018
Closed
@robertnishihara robertnishihara deleted the fixredis branch November 25, 2018 00:49
@robertnishihara robertnishihara mentioned this pull request Nov 25, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devin-petersohn devin-petersohn devin-petersohn approved these changes

Assignees

@devin-petersohn devin-petersohn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ray does not work with most recent version of redis
3 participants
@robertnishihara @AmplabJenkins @devin-petersohn