Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] support python worker command in raylet #3092

Merged
merged 1 commit into from
Oct 24, 2018

Conversation

chuxi
Copy link
Contributor

@chuxi chuxi commented Oct 19, 2018

What do these changes do?

support raylet, which is started by java runManager, to start python default_worker.py .

So when doing local test of java call python task, it helps auto start python worker.

Related issue number

@chuxi chuxi changed the title support python worker command in raylet [Java] support python worker command in raylet Oct 19, 2018
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/8755/
Test FAILed.

@chuxi
Copy link
Contributor Author

chuxi commented Oct 19, 2018

... @AmplabJenkins restart?

How to apply the privilege to restart the failed ci test? ;(

@raulchen
Copy link
Contributor

@chuxi you can close and reopen this PR to trigger CI

@raulchen
Copy link
Contributor

@chuxi you can close and reopen this PR to trigger CI

@chuxi
Copy link
Contributor Author

chuxi commented Oct 20, 2018

@raulchen get it. Thank you!

@chuxi chuxi closed this Oct 20, 2018
@chuxi chuxi reopened this Oct 20, 2018
@raulchen
Copy link
Contributor

hmm, weird that the last CI job kept failing... let me try again

1 similar comment
@raulchen
Copy link
Contributor

hmm, weird that the last CI job kept failing... let me try again

@chuxi chuxi force-pushed the java-raylet-python-worker-cmd branch from 6a26946 to db04262 Compare October 22, 2018 04:58
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/8794/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/8801/
Test FAILed.

@chuxi
Copy link
Contributor Author

chuxi commented Oct 23, 2018

@raulchen ...

why you always post two same comments ... :p

The ray test is broken actually. I will rebase master and push again.

@chuxi chuxi force-pushed the java-raylet-python-worker-cmd branch from db04262 to 002edc9 Compare October 23, 2018 03:18
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/8822/
Test FAILed.

@chuxi
Copy link
Contributor Author

chuxi commented Oct 23, 2018

@robertnishihara

... so is the master branch ci broken? I did not change any code except java, but the failed tests are python's ... :(

@robertnishihara
Copy link
Collaborator

The Jenkins failure should be fixed in #3112. Some of the Travis tests are a little flakey.

@chuxi chuxi force-pushed the java-raylet-python-worker-cmd branch from 002edc9 to f71d682 Compare October 23, 2018 07:49
@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/8827/
Test PASSed.

@chuxi
Copy link
Contributor Author

chuxi commented Oct 24, 2018

rerun failed test or merge directly ?

@raulchen raulchen merged commit 7c1fd19 into ray-project:master Oct 24, 2018
@chuxi chuxi deleted the java-raylet-python-worker-cmd branch October 24, 2018 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants