Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[xray] push warning to driver for infeasible tasks #2784

Merged
merged 3 commits into from
Sep 1, 2018
Merged

[xray] push warning to driver for infeasible tasks #2784

merged 3 commits into from
Sep 1, 2018

Conversation

atumanov
Copy link
Contributor

What do these changes do?

This PR pushes a warning to the user for infeasible tasks to alert them to the fact that they can't currently be executed.

Related issue number

fixes #2780

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/7900/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/7911/
Test PASSed.

robertnishihara
robertnishihara reviewed Aug 31, 2018
View reviewed changes
Copy link
Collaborator

@robertnishihara robertnishihara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tried this out and it looks great. I think I'll add a test for it and push that.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/7922/
Test FAILed.

@robertnishihara
Copy link
Collaborator

jenkins, retest this please

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/7927/
Test FAILed.

@robertnishihara
Copy link
Collaborator

jenkins, retest this please

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/7930/
Test PASSed.

@atumanov
Copy link
Contributor Author

atumanov commented Sep 1, 2018

great, thanks, the test looks good to me as well.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/7931/
Test PASSed.

@robertnishihara robertnishihara merged commit fdc9688 into ray-project:master Sep 1, 2018
@robertnishihara robertnishihara deleted the pushinfeasible branch September 1, 2018 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertnishihara robertnishihara robertnishihara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[xray] Users get no warning for infeasible tasks.
3 participants
@atumanov @AmplabJenkins @robertnishihara