Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] RLlib concepts consolidation, user guide, RL conf prep #22496

Merged
merged 12 commits into from
Feb 18, 2022

Conversation

maxpumperla
Copy link
Contributor

@maxpumperla maxpumperla commented Feb 18, 2022

Preview: RLlib docs

  • Two key concepts pages merged into one (addresses [Docs] RLlib: Only have one "Concepts" page  #21832 partly, but need more concepts, still)
  • Main navigation was cleaned up and organised into a user guide. Also still needs more love, but the project is hopefully a little easier to navigate.
  • TOC page was partly merged into landing page, rest was removed (no value over docs nav and other content)
  • We now have a central announcement include (header and footer) to advertise our conference (as per input from Asawari). Sticky banner on the lower right can also be configured.

Screenshot 2022-02-18 at 13 31 31

Checks

Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
@maxpumperla maxpumperla added the docs An issue or change related to documentation label Feb 18, 2022
maxpumperla and others added 4 commits February 18, 2022 14:32
Co-authored-by: Sven Mika <svenmika1977@gmail.com>
Co-authored-by: Sven Mika <svenmika1977@gmail.com>
Co-authored-by: Sven Mika <svenmika1977@gmail.com>
Co-authored-by: Sven Mika <svenmika1977@gmail.com>
Copy link
Contributor

@sven1977 sven1977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really cool! Thanks for cleaning this up and reorganizing the content. Just a few nits, then let's merge. :)

@sven1977 sven1977 added the rllib RLlib related issues label Feb 18, 2022
@sven1977 sven1977 self-assigned this Feb 18, 2022
Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
@sven1977
Copy link
Contributor

sven1977 commented Feb 18, 2022

Thanks for the fixes! Waiting for tests to pass ...

@simon-mo
Copy link
Contributor

Because this contain doc only changes and passed lint + readthedocs build, and time sensitive, i'm merging this without macOS build (which is under provisioned and not relevant to current PR).

@simon-mo simon-mo merged commit 9482f03 into master Feb 18, 2022
@simon-mo simon-mo deleted the mp_rllib_struct branch February 18, 2022 17:35
@maxpumperla maxpumperla assigned maxpumperla and unassigned sven1977 Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs An issue or change related to documentation rllib RLlib related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants