Skip to content

[DataFrame] Implement diff - #1996

Merged
devin-petersohn merged 8 commits into
ray-project:masterfrom
11rohans:diff
May 5, 2018
Merged

[DataFrame] Implement diff#1996
devin-petersohn merged 8 commits into
ray-project:masterfrom
11rohans:diff

Conversation

@11rohans

@11rohans 11rohans commented May 3, 2018

Copy link
Copy Markdown
Contributor

Implements DataFrame.diff

@AmplabJenkins

AmplabJenkins commented May 3, 2018

Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/5166/
Test FAILed.

@AmplabJenkins

AmplabJenkins commented May 3, 2018

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/5176/
Test PASSed.

@kunalgosar

kunalgosar commented May 3, 2018

Copy link
Copy Markdown
Contributor

Dtypes PR was merged in so this can be rebased on master now.

kunalgosar
kunalgosar suggested changes May 3, 2018
View reviewed changes

@kunalgosar kunalgosar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! Probably doesn't require the rebase on #1930 and #1956 though.

Comment thread python/ray/dataframe/dataframe.py Outdated

@kunalgosar kunalgosar May 3, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can use axis = pd.DataFrame()._get_axis_number(axis) here.

Comment thread python/ray/dataframe/dataframe.py Outdated

@kunalgosar kunalgosar May 3, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some code can be reused between the two functions here. There are examples that do similar things, eg: mode.

Comment thread python/ray/dataframe/test/test_dataframe.py Outdated

@kunalgosar kunalgosar May 3, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try different axis and period values in the tests.

@AmplabJenkins

AmplabJenkins commented May 4, 2018

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/5194/
Test PASSed.

@AmplabJenkins

AmplabJenkins commented May 4, 2018

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/5196/
Test PASSed.

@11rohans

11rohans commented May 4, 2018

Copy link
Copy Markdown
Contributor Author

Comments resolved

@AmplabJenkins

AmplabJenkins commented May 4, 2018

Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/5222/
Test FAILed.

@AmplabJenkins

AmplabJenkins commented May 4, 2018

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/5221/
Test PASSed.

@AmplabJenkins

AmplabJenkins commented May 4, 2018

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/5223/
Test PASSed.

kunalgosar
kunalgosar approved these changes May 4, 2018
View reviewed changes

@kunalgosar kunalgosar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@kunalgosar

kunalgosar commented May 4, 2018

Copy link
Copy Markdown
Contributor

Can you resolve flake issues?

@11rohans

11rohans commented May 4, 2018

Copy link
Copy Markdown
Contributor Author

resolved flake8

@AmplabJenkins

AmplabJenkins commented May 4, 2018

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/5226/
Test PASSed.

@devin-petersohn
devin-petersohn merged commit 8509a51 into ray-project:master May 5, 2018
@devin-petersohn

devin-petersohn commented May 5, 2018

Copy link
Copy Markdown
Member

Passes private-travis. Merged, thanks @11rohans

alok added a commit to alok/ray that referenced this pull request May 8, 2018
@alok
Merge branch 'master' into trpo
0fd8f4a 
* master: (21 commits)
  Expand local_dir in Trial init (ray-project#2013)
  Fixing ascii error for Python2 (ray-project#2009)
  [DataFrame] Implements df.update (ray-project#1997)
  [DataFrame] Implements df.as_matrix (ray-project#2001)
  [DataFrame] Implement quantile (ray-project#1992)
  [DataFrame] Impement sort_values and sort_index (ray-project#1977)
  [DataFrame] Implement rank (ray-project#1991)
  [DataFrame] Implemented prod, product, added test suite (ray-project#1994)
  [DataFrame] Implemented __setitem__, select_dtypes, and astype (ray-project#1941)
  [DataFrame] Implement diff (ray-project#1996)
  [DataFrame] Implemented nunique, skew (ray-project#1995)
  [DataFrame] Implements filter and dropna (ray-project#1959)
  [DataFrame] Implements df.pipe (ray-project#1999)
  [DataFrame] Apply() for Lists and Dicts (ray-project#1973)
  Clean up syntax for supported Python versions. (ray-project#1963)
  [DataFrame] Implements mode, to_datetime, and get_dummies (ray-project#1956)
  [DataFrame] Fix dtypes (ray-project#1930)
  keep_dims -> keepdims (ray-project#1980)
  add pthread linking (ray-project#1986)
  [DataFrame] Add layer of abstraction to allow OID instantiation (ray-project#1984)
  ...
alok added a commit to alok/ray that referenced this pull request May 9, 2018
@alok
Merge branch 'master' into comps
329834e 
* master: (25 commits)
  [DataFrame] Add direct pandas imports for MVP (ray-project#1960)
  Make ActorHandles pickleable, also make proper ActorHandle and ActorC… (ray-project#2007)
  Expand local_dir in Trial init (ray-project#2013)
  Fixing ascii error for Python2 (ray-project#2009)
  [DataFrame] Implements df.update (ray-project#1997)
  [DataFrame] Implements df.as_matrix (ray-project#2001)
  [DataFrame] Implement quantile (ray-project#1992)
  [DataFrame] Impement sort_values and sort_index (ray-project#1977)
  [DataFrame] Implement rank (ray-project#1991)
  [DataFrame] Implemented prod, product, added test suite (ray-project#1994)
  [DataFrame] Implemented __setitem__, select_dtypes, and astype (ray-project#1941)
  [DataFrame] Implement diff (ray-project#1996)
  [DataFrame] Implemented nunique, skew (ray-project#1995)
  [DataFrame] Implements filter and dropna (ray-project#1959)
  [DataFrame] Implements df.pipe (ray-project#1999)
  [DataFrame] Apply() for Lists and Dicts (ray-project#1973)
  Clean up syntax for supported Python versions. (ray-project#1963)
  [DataFrame] Implements mode, to_datetime, and get_dummies (ray-project#1956)
  [DataFrame] Fix dtypes (ray-project#1930)
  keep_dims -> keepdims (ray-project#1980)
  ...
alok added a commit to alok/ray that referenced this pull request May 9, 2018
@alok
Merge branch 'master' into magic-methods
601e67b 
* master:
  [DataFrame] Add direct pandas imports for MVP (ray-project#1960)
  Make ActorHandles pickleable, also make proper ActorHandle and ActorC… (ray-project#2007)
  Expand local_dir in Trial init (ray-project#2013)
  Fixing ascii error for Python2 (ray-project#2009)
  [DataFrame] Implements df.update (ray-project#1997)
  [DataFrame] Implements df.as_matrix (ray-project#2001)
  [DataFrame] Implement quantile (ray-project#1992)
  [DataFrame] Impement sort_values and sort_index (ray-project#1977)
  [DataFrame] Implement rank (ray-project#1991)
  [DataFrame] Implemented prod, product, added test suite (ray-project#1994)
  [DataFrame] Implemented __setitem__, select_dtypes, and astype (ray-project#1941)
  [DataFrame] Implement diff (ray-project#1996)
  [DataFrame] Implemented nunique, skew (ray-project#1995)
  [DataFrame] Implements filter and dropna (ray-project#1959)
  [DataFrame] Implements df.pipe (ray-project#1999)
  [DataFrame] Apply() for Lists and Dicts (ray-project#1973)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devin-petersohn devin-petersohn devin-petersohn approved these changes
+1 more reviewer
@kunalgosar kunalgosar kunalgosar approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@11rohans @AmplabJenkins @kunalgosar @devin-petersohn