Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Pin aiohttp version to fix master branch #19948

Merged
merged 2 commits into from
Nov 2, 2021

Conversation

simon-mo
Copy link
Contributor

@simon-mo simon-mo commented Nov 1, 2021

Why are these changes needed?

aiohttp 3.8.0 release broke our tests.

Traceback (most recent call last):
  File "/ray/python/ray/_private/services.py", line 1262, in start_dashboard
    import ray.dashboard.optional_deps  # noqa: F401
  File "/ray/python/ray/dashboard/optional_deps.py", line 8, in <module>
    import aiohttp.signals
ModuleNotFoundError: No module named 'aiohttp.signals'

ping for now, going to fix it soon.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@simon-mo
Copy link
Contributor Author

simon-mo commented Nov 1, 2021

i'll merge after confirming it works. ETA 30min

@edoakes
Copy link
Contributor

edoakes commented Nov 1, 2021

@simon-mo looks like it's still failing.

@fishbone
Copy link
Contributor

fishbone commented Nov 1, 2021

@simon-mo I suspect it might be related to buildkite change. When I run the docker image locally, the failed tests actually passed

@simon-mo
Copy link
Contributor Author

simon-mo commented Nov 2, 2021

missed a file, the version was still 3.8.0 in some tests.

@jjyao
Copy link
Collaborator

jjyao commented Nov 2, 2021

Is it possible that we have a central place for defining aiohttp dependency?

@fishbone fishbone mentioned this pull request Nov 2, 2021
6 tasks
@simon-mo simon-mo merged commit 6040319 into ray-project:master Nov 2, 2021
@WangTaoTheTonic
Copy link
Contributor

nice fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants