Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove num_threads as a parameter. #1891

Merged
merged 8 commits into from
Apr 14, 2018
Merged

Remove num_threads as a parameter. #1891

merged 8 commits into from
Apr 14, 2018

Conversation

elibol
Copy link
Contributor

@elibol elibol commented Apr 13, 2018

Removes num_threads as a parameter. This corrects the "mac" issue on #1827. It allows the system to make progress by always maintaining non-zero number of threads for receiving data.

elibol added a commit to elibol/ray that referenced this pull request Apr 13, 2018
@elibol
update test configuration to reflect changes in ray-project#1891
d64f7c1
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4851/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4856/
Test FAILed.

@elibol elibol mentioned this pull request Apr 13, 2018
Merged
pcmoritz
pcmoritz approved these changes Apr 13, 2018
View reviewed changes
Copy link
Contributor

@pcmoritz pcmoritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's merge once the tests pass

@elibol
Copy link
Contributor Author

elibol commented Apr 13, 2018

https://travis-ci.com/robertnishihara/ray-private-travis/builds/70822225

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4881/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4883/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4889/
Test FAILed.

@pcmoritz pcmoritz force-pushed the melih/remove_thread_as_param branch from 927a46a to 12aa5d4 Compare April 14, 2018 03:42
pcmoritz pushed a commit to elibol/ray that referenced this pull request Apr 14, 2018
@elibol @pcmoritz
update tests to reflect changes in ray-project#1891.
8cf1e36
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4893/
Test FAILed.

@pcmoritz
Copy link
Contributor

retest this please

pcmoritz pushed a commit that referenced this pull request Apr 14, 2018
@elibol @pcmoritz
Adds Valgrind tests for multi-threaded object manager. (#1890)
6be7335 
* adds valgrind to new object manager.

* Add some comments.

* Update run_object_manager_valgrind.sh

typo

* Update run_object_manager_tests.sh

* update tests to reflect changes in #1891.

* reduce # tests.
@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4895/
Test PASSed.

@pcmoritz pcmoritz merged commit 6a84b1f into ray-project:master Apr 14, 2018
pcmoritz pushed a commit that referenced this pull request Apr 15, 2018
@elibol @pcmoritz
Single Big Object Parallel Transfer. (#1827)
fcd3044 
* cache all object info from object added store notification.

* Adds parallel transfer for big objects.

* documentation and clean up.

* compare objects...

* merge buffer_state with chunk vec. Make separate buffer state for get and create.

* use references for Get. Allow partial failure of Create.

* single plasma client.

* changes based on review.

* update documentation and add parameters for object manager in main.cc.

* review feedback.

* use vector consturctor.

* linting

* remove profile visualizations.

* test fixes.

* linting.

* kill specific pids and use less memory.

* linting.

* simplify tests.

* Asynchronous IO for ObjectManager messages and object transfer.

* Revert "Asynchronous IO for ObjectManager messages and object transfer."

This reverts commit 4af43b1.

* update test configuration to reflect changes in #1891

* review feedback.

* linting.
royf added a commit to royf/ray that referenced this pull request Apr 22, 2018
@royf
Merge branch 'master' into softq
40ed3a0 
* master: (56 commits)
  [xray] Turn on flushing to the GCS for the lineage cache (ray-project#1907)
  Single Big Object Parallel Transfer. (ray-project#1827)
  Remove num_threads as a parameter. (ray-project#1891)
  Adds Valgrind tests for multi-threaded object manager. (ray-project#1890)
  Pin cython version in docker base dependencies file. (ray-project#1898)
  Update arrow to efficiently serialize more types of numpy arrays. (ray-project#1889)
  updates (ray-project#1896)
  [DataFrame] Inherit documentation from Pandas (ray-project#1727)
  Update arrow and parquet-cpp. (ray-project#1875)
  raylet command line resource configuration plumbing (ray-project#1882)
  use raylet for remote ray nodes (ray-project#1880)
  [rllib] Propagate dim option to deepmind wrappers (ray-project#1876)
  [RLLib] DDPG (ray-project#1685)
  Lint Python files with Yapf (ray-project#1872)
  [DataFrame] Fixed repr, info, and memory_usage (ray-project#1874)
  Fix getattr compat (ray-project#1871)
  check if arrow build dir exists (ray-project#1863)
  [DataFrame] Encapsulate index and lengths into separate class (ray-project#1849)
  [DataFrame] Implemented __getattr__ (ray-project#1753)
  Add better analytics to docs (ray-project#1854)
  ...

# Conflicts:
#	python/ray/rllib/__init__.py
#	python/setup.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcmoritz pcmoritz pcmoritz approved these changes

@robertnishihara robertnishihara Awaiting requested review from robertnishihara

@atumanov atumanov Awaiting requested review from atumanov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elibol @AmplabJenkins @pcmoritz