[RLlib] Bump tf version in ML docker to tf==2.5.0; add tfp to ML-docker. #18544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjoliver
reviewed
Sep 13, 2021
gjoliver
reviewed
Sep 13, 2021
| @@ -29,5 +29,8 @@ RUN sudo apt-get update \ | |||
| && sudo rm requirements_tune.txt && sudo rm requirements_rllib.txt \ | |||
| && sudo apt-get clean | |||
|
|
|||
| # Make sure tfp is installed correctly and matches tf version. | |||
| RUN python -c "import tensorflow_probability" | |||
There was a problem hiding this comment.
actually, I don't know if checks are usually included as part of the image build process?
I think a lot of things happen when you import tf for the first time? and those will be baked into the prod image now.
although, this is really nice. we should have some ways to test an image once it's built.
There was a problem hiding this comment.
actually, I notice Kai asked for it in a conversation.
maybe we can add a comment and call it a day for now.
we should probably merge this sooner.
gjoliver
approved these changes
Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number
Checks
scripts/format.shto lint the changes in this PR.