Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tune] Fix hyperopt points to evaluate for nested lists #18113

Merged
merged 2 commits into from
Aug 26, 2021

Conversation

krfricke
Copy link
Contributor

Why are these changes needed?

Internal hyperopt parameter names are flattened for lists (e.g. nested/0, nested/1). However, when supplying points_to_evaluate, we have to flatten those names as well, as they otherwise cannot be mapped to the internal names.

Related issue number

Closes #14470

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@krfricke krfricke merged commit 34cf5db into ray-project:master Aug 26, 2021
@krfricke krfricke deleted the suggest/hyperopt-nested branch August 26, 2021 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[tune] HyperOpt AssertionError if setting points_to_evaluate
3 participants