[DataFrame] Implemented cummax, cummin, cumsum, cumprod #1705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test PASSed. |
python/ray/dataframe/dataframe.py
Outdated
| Returns: | ||
| The cumulative maximum of the DataFrame. | ||
| """ | ||
| if(axis == 1): |
There was a problem hiding this comment.
There are a couple instances if this that are probably linting errors. Should just be if axis == 1:
There was a problem hiding this comment.
Ok, I will fix these.
robertnishihara
approved these changes
Mar 13, 2018
|
Test PASSed. |
|
Test PASSed. |
|
Test failures unrelated. OK to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hsubbaraj I tried to rebase for you but ran into problems because you were editing your master branch. I went ahead and submitted a new PR with the same commit history.