-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[autoscaler] [tune] More doc fixes #1560
Conversation
Test PASSed. |
Test PASSed. |
Test PASSed. |
@vlad17 didn't you also need |
@richardliaw yeah |
Test PASSed. |
Test PASSed. |
@@ -80,6 +81,9 @@ file_mounts: { | |||
|
|||
# List of shell commands to run to set up nodes. | |||
setup_commands: | |||
# Consider uncommenting these if you run into dpkg locking issues | |||
# - sudo pkill -9 apt-get || true | |||
# - sudo pkill -9 dpkg || true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not also
- sudo dpkg --configure -a
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Test PASSed. |
doc/source/autoscaling.rst
Outdated
@@ -31,7 +31,7 @@ To run connect to applications running on the cluster (e.g. Jupyter notebook) us | |||
|
|||
.. code-block:: bash | |||
|
|||
$ ssh -L 8899:localhost:8899 -i <key> <user>@<addr> jupyter notebook --port=8899 | |||
$ ssh -L 8899:localhost:8899 -i <key> <user>@<addr> 'source ~/anaconda3/bin/activate tensorflow_p36 && jupyter notebook --port=8899` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this work? the example.yaml
doesn't install in this env right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright I changed this to install ray into tensorflow_p36
, and updated the doc accordingly.
Test PASSed. |
@ericl sphinx lint failed |
Also added a full mnist example for hyperband (requested by user). |
Test PASSed. |
Test PASSed. |
Test PASSed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; would probably be nice to put a smoke test in for the example
Good though, added smoke test |
Test FAILed. |
Test PASSed. |
Test hang looks unrelated, merging |
* 'master' of https://github.com/royf/ray-private: [rllib] Basic regression tests on CartPole (ray-project#1608) [autoscaler] [tune] More doc fixes (ray-project#1560) [tune] Hyperband Max Iter Fix (ray-project#1620)
What do these changes do?
Related issue number