fix setting log-level to debug. #1432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged build finished. Test PASSed. |
|
Test PASSed. |
robertnishihara
approved these changes
Jan 16, 2018
|
I'll merge this once the tests have run. |
robertnishihara
force-pushed
the
melih/fixdebug
branch
from
f724b50 to
eef6e63
Compare
|
Just repushed in order to trigger travis again. |
|
Merged build finished. Test PASSed. |
|
Test PASSed. |
pcmoritz
approved these changes
Jan 20, 2018
|
+1 LGTM, the test failures look unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Setting log-level to DEBUG triggers a slew of issues. These issues have been fixed by using the appropriate format for various logged variables.
Related issue number
None