Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes default type for product of empty shape. #1341

Merged
merged 1 commit into from
Dec 19, 2017
Merged

fixes default type for product of empty shape. #1341

merged 1 commit into from
Dec 19, 2017

Conversation

elibol
Copy link
Contributor

@elibol elibol commented Dec 18, 2017

What do these changes do?

When shapes is empty, size is of type float, which breaks indexing on vector.

Related issue number

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/2830/
Test PASSed.

@pcmoritz pcmoritz self-requested a review December 19, 2017 01:41
pcmoritz
pcmoritz approved these changes Dec 19, 2017
View reviewed changes
Copy link
Contributor

@pcmoritz pcmoritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@pcmoritz pcmoritz merged commit 24b93b1 into ray-project:master Dec 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcmoritz pcmoritz pcmoritz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elibol @AmplabJenkins @pcmoritz