Fix overlooked typo. #1158
Merged
Fix overlooked typo. #1158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this the example script would crash with an UnboundLocalError.
|
Can one of the admins verify this patch? |
|
ok to test |
|
Good catch, thanks for the fix! |
|
Merged build finished. Test PASSed. |
|
Test PASSed. |
richardliaw
approved these changes
Oct 24, 2017
|
Looks like flake8 was updated on PyPI yesterday, which is probably the source of the linting errors. https://pypi.python.org/pypi/flake8 |
|
@richardliaw Can you fix the linting errors in a separate PR? |
|
Sure.
…On Tue, Oct 24, 2017 at 12:38 PM, Philipp Moritz ***@***.***> wrote:
@richardliaw <https://github.com/richardliaw> Can you fix the linting
errors in a separate PR?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1158 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEUc5RWI9g-1--aV1Xcn-Ig2cIkGXe1Uks5svjzEgaJpZM4QEu93>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this the example script would crash with an UnboundLocalError.